lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove
    At Thu,  1 Oct 2009 10:28:10 +0200,
    Uwe Kleine-König wrote:
    >
    > The function hal2_remove is defined using __exit, so don't use __devexit_p
    > but __exit_p to wrap it.

    I think it's the other way round. We should replace __exit with __devexit.
    Ditto for sound/mips/sgio2audio.c.


    thanks,

    Takashi

    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > Cc: Takashi Iwai <tiwai@suse.de>
    > Cc: Jaroslav Kysela <perex@perex.cz>
    > Cc: alsa-devel@alsa-project.org
    > Cc: linux-kernel@vger.kernel.org
    > ---
    > sound/mips/hal2.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c
    > index c52691c..72523a7 100644
    > --- a/sound/mips/hal2.c
    > +++ b/sound/mips/hal2.c
    > @@ -926,7 +926,7 @@ static int __exit hal2_remove(struct platform_device *pdev)
    >
    > static struct platform_driver hal2_driver = {
    > .probe = hal2_probe,
    > - .remove = __devexit_p(hal2_remove),
    > + .remove = __exit_p(hal2_remove),
    > .driver = {
    > .name = "sgihal2",
    > .owner = THIS_MODULE,
    > --
    > 1.6.4.3
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-01 10:43    [W:0.045 / U:0.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site