lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] Fix dubious bitwise 'and' usage spotted by sparse.
On Sat, 10 Jan 2009, Alexey Zaytsev wrote:

> It doesn't change the semantics, but it looks like
> the logical 'and' was meant to be used here.
>
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
> ---
> drivers/net/wireless/ath9k/rc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath9k/rc.c b/drivers/net/wireless/ath9k/rc.c
> index cca2fc5..e8eb20d 100644
> --- a/drivers/net/wireless/ath9k/rc.c
> +++ b/drivers/net/wireless/ath9k/rc.c
> @@ -609,7 +609,7 @@ ath_rc_get_nextvalid_txrate(const struct ath_rate_table *rate_table,
>
> static int ath_rc_valid_phyrate(u32 phy, u32 capflag, int ignore_cw)
> {
> - if (WLAN_RC_PHY_HT(phy) & !(capflag & WLAN_RC_HT_FLAG))
> + if (WLAN_RC_PHY_HT(phy) && !(capflag & WLAN_RC_HT_FLAG))
> return FALSE;
> if (WLAN_RC_PHY_DS(phy) && !(capflag & WLAN_RC_DS_FLAG))
> return FALSE;

This one needs a small fixup, as the buggy code got moved around to
ath_rc_valid_phyrate().

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2009-01-10 01:01    [W:0.091 / U:0.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site