lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] x86, pat: fix reserve_memtype() for legacy 1MB range
    From: Suresh Siddha <suresh.b.siddha@intel.com>
    Subject: x86, pat: fix reserve_memtype() for legacy 1MB range

    Thierry Vignaud reported:
    > http://bugzilla.kernel.org/show_bug.cgi?id=12372
    >
    > On P4 with an SiS motherboard (video card is a SiS 651)
    > X server fails to start with error:
    > xf86MapVidMem: Could not mmap framebuffer (0x00000000,0x2000) (Invalid
    > argument)

    Here X is trying to map first 8KB of memory using /dev/mem. Existing
    code treats first 0-4KB of memory as non-RAM and 4KB-8KB as RAM. Recent
    code changes don't allow to map memory with different attributes
    at the same time.

    Fix this by treating the first 1MB legacy region as special and always
    track the attribute requests with in this region using linear linked
    list (and don't bother if the range is RAM or non-RAM or mixed)

    Reported-and-tested-by: Thierry Vignaud <tvignaud@mandriva.com>
    Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
    Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
    Cc: stable@kernel.org
    ---

    diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
    index 85cbd3c..c959a4d 100644
    --- a/arch/x86/mm/pat.c
    +++ b/arch/x86/mm/pat.c
    @@ -333,11 +333,20 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
    req_type & _PAGE_CACHE_MASK);
    }

    - is_range_ram = pagerange_is_ram(start, end);
    - if (is_range_ram == 1)
    - return reserve_ram_pages_type(start, end, req_type, new_type);
    - else if (is_range_ram < 0)
    - return -EINVAL;
    + /*
    + * For legacy reasons, some parts of the physical address range in the
    + * legacy 1MB region is treated as non-RAM (even when listed as RAM in
    + * the e820 tables). So we will track the memory attributes of this
    + * legacy 1MB region using the linear memtype_list always.
    + */
    + if (end >= ISA_END_ADDRESS) {
    + is_range_ram = pagerange_is_ram(start, end);
    + if (is_range_ram == 1)
    + return reserve_ram_pages_type(start, end, req_type,
    + new_type);
    + else if (is_range_ram < 0)
    + return -EINVAL;
    + }

    new = kmalloc(sizeof(struct memtype), GFP_KERNEL);
    if (!new)

    \
     
     \ /
      Last update: 2009-01-09 23:39    [W:0.021 / U:1.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site