lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/16] dma-debug: add add checking for map/unmap_sg
    On Fri, Jan 09, 2009 at 05:19:24PM +0100, Joerg Roedel (joerg.roedel@amd.com) wrote:
    > +void debug_map_sg(struct device *dev, struct scatterlist *sg,
    > + int nents, int direction)
    > +{
    > + struct dma_debug_entry *entry;
    > + struct scatterlist *s;
    > + int i;
    > +
    > + if (global_disable)
    > + return;
    > +
    > + for_each_sg(sg, s, nents, i) {
    > + entry = dma_entry_alloc();
    > + if (!entry)
    > + return;
    > +
    > + entry->type = dma_debug_sg;
    > + entry->dev = dev;
    > + entry->cpu_addr = sg_virt(s);
    > + entry->size = s->length;
    > + entry->dev_addr = s->dma_address;
    > + entry->direction = direction;
    > +
    > + add_dma_entry(entry);
    > + }
    > +}
    > +EXPORT_SYMBOL(debug_map_sg);
    > +
    > +void debug_unmap_sg(struct device *dev, struct scatterlist *sglist,
    > + int nelems, int dir)
    > +{
    > + struct scatterlist *s;
    > + int i;
    > +
    > + if (global_disable)
    > + return;
    > +
    > + for_each_sg(sglist, s, nelems, i) {
    > +
    > + struct dma_debug_entry ref = {
    > + .type = dma_debug_sg,
    > + .dev = dev,
    > + .cpu_addr = sg_virt(s),
    > + .dev_addr = s->dma_address,
    > + .size = s->length,
    > + .direction = dir,
    > + };
    > +
    > + check_unmap(&ref);

    Will this print false errors if above map debug failed to add an entry
    into the list?

    --
    Evgeniy Polyakov


    \
     
     \ /
      Last update: 2009-01-09 19:11    [W:0.031 / U:0.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site