lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH, v2 4/4] ufs: copy symlink data into the correct union member
    Date
    Copy symlink data into the union member it is accessed through. Although
    this shouldn't make a difference to behaviour it makes the code easier
    to follow and grep through. It may also prevent problems if the
    struct/union definitions change in the future.

    Signed-off-by: Duane Griffin <duaneg@dghda.com>
    ---

    Version 1 -> 2:
    * Remove now obsolete cast; don't take address of the array

    fs/ufs/namei.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c
    index e3a9b1f..23119fe 100644
    --- a/fs/ufs/namei.c
    +++ b/fs/ufs/namei.c
    @@ -147,7 +147,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry,
    } else {
    /* fast symlink */
    inode->i_op = &ufs_fast_symlink_inode_operations;
    - memcpy((char*)&UFS_I(inode)->i_u1.i_data,symname,l);
    + memcpy(UFS_I(inode)->i_u1.i_symlink, symname, l);
    inode->i_size = l-1;
    }
    mark_inode_dirty(inode);
    --
    1.6.0.6


    \
     
     \ /
      Last update: 2009-01-08 23:47    [W:0.019 / U:57.824 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site