Messages in this thread | | | Date | Thu, 08 Jan 2009 11:30:09 -0800 (PST) | Subject | Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver | From | David Miller <> |
| |
From: "Mike Frysinger" <vapier.adi@gmail.com> Date: Thu, 8 Jan 2009 14:05:33 -0500
> On Thu, Jan 8, 2009 at 14:01, Mike Frysinger wrote: > > On Thu, Jan 8, 2009 at 13:55, David Miller wrote: > >> We can get VLAN packets received and sent, using AF_PACKET > >> sockets, for example. The chip should still respect those > >> even if VLAN proper is not being utilized. > > > > any tips on doing that ? > > or rather, is there a driver or you two you can point out that is > doing this correctly ? the ones i looked at seemed to be doing it > like the patch we posted ...
And I disagree with how those drivers are doing it :-)
At least the programming of the chip to accept all packet types properly, VLAN or not, regardless of kernel config, is definitely IMHO the way to go.
| |