lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v5][RFC]: mutex: implement adaptive spinning

On Wed, 7 Jan 2009, Linus Torvalds wrote:
> > Should that be:
> >
> > #if defined(CONFIG_DEBUG_PAGEALLOC) || defined(CONFIG_MEMORY_HOTPLUG)
>
> Well, probably CONFIG_MEMORY_HOTREMOVE, no? And I'd actually suggest that
> unplugging should have a stop-machine if it doesn't already, just because
> it's such a special case - like module removal.

I do not think stop-machine will help, unless that spinning is protected
by preempt-disable. If the task gets preempted after grabbing the owner
thread_info, and then stop-machine runs, the memory disappears, the task
is scheduled back, accesses the owner thread_info and then page-fault.

-- Steve



\
 
 \ /
  Last update: 2009-01-08 03:37    [W:0.150 / U:27.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site