lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bug: Status/Summary of slashdot leap-second crash on new years 2008-2009
Once upon a time, David Newall <davidn@davidnewall.com> said:
> I went back to the start of the thread. Chris posted a stack trace
> showing "#15 0xffffffff8104ec16 in ntp_leap_second (timer=<value
> optimized out>) at kernel/time/ntp.c:143". That would be kernel code to
> process leap seconds from NTP broadcasts, I think. That code needs to
> be removed.

Well, the code is to process when the kernel is told about leap seconds
(it doesn't have to be NTP, you can do it with adjtimex, which is what I
did to track down the problem).

But why should it be removed? Why change Linux to be incompatible with
POSIX and other Unix systems? This could create real problems with
things like network file systems for example. Even trying to get
interoperation between UTC-Linux and TAI-Linux would be a PITA.

There was a bug, there is a patch, it should be fixed. There's no
reason to reinvent the wheel just because there was a bug.

Looking at comments, there was another bug related to the same
xtime_lock/printk issue but not in leap second related code; it was
trying to print a message about changing clock sources. Should we now
re-architect all of that as well?

--
Chris Adams <cmadams@hiwaay.net>
Systems and Network Administrator - HiWAAY Internet Services
I don't speak for anybody but myself - that's enough trouble.


\
 
 \ /
  Last update: 2009-01-07 23:15    [W:0.114 / U:5.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site