lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/4] ftrace: important updates
On Wed, 7 Jan 2009 10:49:05 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > ring-buffer: rename debugfs file tracing_on to writing_enabled
>
> writing_enabled is at least as confusing as tracing_on - if not more so.
>
> The user really does not care about all the deeper machinery that happens
> in ftrace - the difference between a 'light' disabling of a tracer and a
> 'heavy' disabling of a tracer (which means it unregisters itself
> completely in essence).
>
> To resolve this, we should probably hide this difference altogether (as i
> have suggested to do many months ago, when this first came up), by
> removing tracing_enabled.
>
> A tracer can still be fully unregistered: by simply switching the current
> tracer to the 'nop' tracer. tracing_on/off remains the lightweight version
> that most users are interested in anyway.

This sounds even better. We should not need tracing_enabled anymore, since
the buffer size can be changed regardless. tracing_on is more useful to
mmiotrace than tracing_enabled, too, since mmiotrace does not implement
the proper pausing behaviour on the tracing_enabled trigger.

But if Steven wants to keep the "pause" semantics, should there be a
callback dispatched to the tracer from tracing_on, just like there is
from tracing_enabled currently? Of course the callback semantics would
be different and the usual reaction would be to do nothing. It would
only be meaningful to tracers that update data outside the ring buffer,
so that they can properly pause.

--
Pekka Paalanen
http://www.iki.fi/pq/


\
 
 \ /
  Last update: 2009-01-07 18:57    [W:1.150 / U:5.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site