lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [3/5] Mark complex bitops.h inlines as __always_inline

* Hugh Dickins <hugh@veritas.com> wrote:

> Hugh Dickins noticed that released gcc versions building the kernel with
> CONFIG_OPTIMIZE_INLINING=y don't inline some of the bitops - sometimes
> generating very inefficient pageflag tests, and many instances of
> constant_test_bit().

Could you quantify that please?

We really dont want to reintroduce __always_inline just for performance /
code size reasons. If GCC messes up and makes a larger / more inefficient
kernel, GCC will be fixed. CONFIG_OPTIMIZE_INLINING is default-off, so
enable it only if it improves your kernel.

Ingo


\
 
 \ /
  Last update: 2009-01-07 14:21    [W:0.113 / U:3.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site