[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Data corruption issue with splice() on
On Wed, Jan 07, 2009 at 11:42:46PM +1100, Herbert Xu ( wrote:
> > Doesn't your tcp fallbacks to kernel_sendmsg() without sg in
> > tcp_sendpage()? And then just feeds data into the stack the same way it
> > happens with send() i.e. by copying it.
> Good point. Did he check GSO though? GSO will always enable SG
> on the socket regardless of the netdev's setting. And if the device
> started out with SG enabled then recent kernels will enable GSO
> by default.

Willy, what was the kernel you are tested no-accel behaviour and what
were the gso settings?
Can you add a simple single print into tcp_sendpage() to determine if
content was copied or fed into do_tcp_sendpages() otherwise?

Evgeniy Polyakov

 \ /
  Last update: 2009-01-07 13:49    [W:0.076 / U:3.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site