Messages in this thread | | | Date | Tue, 6 Jan 2009 09:43:12 +0100 | From | Nick Piggin <> | Subject | Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?) |
| |
On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote: > >Index: linux-2.6/include/linux/radix-tree.h > >=================================================================== > >--- linux-2.6.orig/include/linux/radix-tree.h > >+++ linux-2.6/include/linux/radix-tree.h > >@@ -136,7 +136,7 @@ do { \ > > */ > > static inline void *radix_tree_deref_slot(void **pslot) > > { > >- void *ret = *pslot; > >+ void *ret = rcu_dereference(*pslot); > > if (unlikely(radix_tree_is_indirect_ptr(ret))) > > ret = RADIX_TREE_RETRY; > > return ret; > > > > > > The patch above fixes my problem. I did two complete test runs that > normally fail rather quickly.
OK, thanks for reporting and testing.
I think this patch is a candidate for -stable too.
Thanks, Nick
| |