Messages in this thread | | | Date | Mon, 5 Jan 2009 11:13:21 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] mflash linux support |
| |
On Mon, 5 Jan 2009 04:33:46 +0200 Heikki Orsila <shdl@zakalwe.fi> wrote:
> A few style issues:
How about starting by worrying about the code not pointless style complaints ?
>> > + switch (cmd) { > > + case HDIO_GETGEO: > > if (cmd == HDIO_GETGEO) {
Especially when you are making pointless complaints about things that are generally done the way the original code is - and for good reason. It makes it far cleaner to add new ioctl support.
It would be interesting to see what mflash looked like as a libata driver but I think for embedded systems the driver as submitted shows great promise.
| |