lkml.org 
[lkml]   [2009]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: ftrace breaks sparc64 build
    > 
    > Probably the same issue. The problem is that the first use of a variable
    > is in the OR section of an if statement that does a return.
    >
    > if (x || !(y = init_me())
    > return;
    >
    > use_me(y);
    >

    More warnings:
    fs/partitions/check.c: In function `rescan_partitions':
    fs/partitions/check.c:511: warning: 'state' might be used uninitialized in this function

    => follow same pattern

    fs/compat_ioctl.c: In function `ppp_sock_fprog_ioctl_trans':
    fs/compat_ioctl.c:859: warning: 'fptr32' might be used uninitialized in this function
    fs/compat_ioctl.c: In function `do_fontx_ioctl':
    fs/compat_ioctl.c:1082: warning: 'data' might be used uninitialized in this function
    fs/compat_ioctl.c: In function `do_atmif_sioc':
    fs/compat_ioctl.c:1302: warning: 'data' might be used uninitialized in this function
    fs/compat_ioctl.c: In function `do_atm_ioctl':
    fs/compat_ioctl.c:1272: warning: 'data' might be used uninitialized in this function
    fs/compat_ioctl.c: In function `mtd_rw_oob':
    fs/compat_ioctl.c:1421: warning: 'data' might be used uninitialized in this function
    fs/compat_ioctl.c: In function `do_usbdevfs_discsignal':
    fs/compat_ioctl.c:1650: warning: 'uctx' might be used uninitialized in this function

    This is:
    if (get_user(flen, &u_fprog32->len) ||
    get_user(fptr32, &u_fprog32->filter))
    return -EFAULT;


    which is a common pattern. I have at least one in sparc64 code too.
    I did not come up with a nice solution on this one.

    drivers/char/vt_ioctl.c: In function `vt_ioctl':
    drivers/char/vt_ioctl.c:945: warning: 'cc' might be used uninitialized in this function

    get_user() || get_user() again.

    net/core/skbuff.c: In function `___pskb_trim':
    net/core/skbuff.c:1041: warning: 'err' might be used uninitialized in this function

    if (xxx && err = foo())

    net/core/dev.c: In function `skb_gso_segment':
    net/core/dev.c:1537: warning: 'err' might be used uninitialized in this function
    net/core/dev.c: In function `netif_receive_skb':
    net/core/dev.c:2075: warning: 'port' might be used uninitialized in this function

    if (xx && err = ...)
    if (xx || port = ...)

    net/core/neighbour.c: In function `neigh_resolve_output':
    net/core/neighbour.c:1188: warning: 'neigh' might be used uninitialized in this function
    net/core/neighbour.c: In function `neigh_create':
    net/core/neighbour.c:411: warning: 'error' might be used uninitialized in this function

    if (xx || neigh = ...)

    net/ipv4/ip_output.c: In function `ip_append_data':
    net/ipv4/ip_output.c:1006: warning: 'left' might be used uninitialized in this function


    net/ipv4/tcp.c: In function `tcp_sendpage':
    net/ipv4/tcp.c:687: warning: 'copy' might be used uninitialized in this function
    net/ipv4/tcp.c: In function `tcp_sendmsg':
    net/ipv4/tcp.c:862: warning: 'copy' might be used uninitialized in this function
    net/ipv4/tcp.c: In function `tcp_recvmsg':
    net/ipv4/tcp.c:1598: warning: 'chunk' might be used uninitialized in this function


    net/ipv4/tcp_ipv4.c: In function `listening_get_next':
    net/ipv4/tcp_ipv4.c:1874: warning: 'node' might be used uninitialized in this function
    net/ipv4/tcp_ipv4.c: In function `established_get_next':
    net/ipv4/tcp_ipv4.c:2012: warning: 'node' might be used uninitialized in this function

    net/ipv4/raw.c: In function `__raw_v4_lookup':
    net/ipv4/raw.c:113: warning: 'node' might be used uninitialized in this function

    net/ipv4/udp.c: In function `__udp4_lib_rcv':
    net/ipv4/udp.c:325: warning: 'node' might be used uninitialized in this function
    net/ipv4/udp.c:325: warning: 'node' might be used uninitialized in this function

    net/ipv4/devinet.c: In function `inet_gifconf':
    net/ipv4/devinet.c:821: warning: 'ifa' might be used uninitialized in this function

    net/ipv4/ipmr.c: In function `ipmr_get_route':
    net/ipv4/ipmr.c:1629: warning: 'vif' might be used uninitialized in this function

    net/ipv4/syncookies.c: In function `cookie_v4_check':
    net/ipv4/syncookies.c:263: warning: 'mss' might be used uninitialized in this function


    I have two warnings in sparc code I will deal with.
    One of them is the get_user() || get_user() pattern
    so I dunno how to fix it atm.

    The above is from a:
    make ARCH=sparc64 allmodconfig
    make ARCH=sparc64 vmlinux

    I did not try to build modules...

    Sam


    \
     
     \ /
      Last update: 2009-01-05 22:33    [W:0.026 / U:29.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site