lkml.org 
[lkml]   [2009]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86 PCI: Do not use interrupt links for devices using MSI-X
Date
On Monday, January 5, 2009 5:04 am Ingo Molnar wrote:
> * Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > pcibios_enable_device() and pcibios_disable_device() don't handle
> > IRQs for devices that have MSI enabled and it should tread the
>
> s/tread/treat
>
> > devices with MSI-X enabled in the same way.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > arch/x86/pci/common.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> looks good - Jesse, what do you think?

Yeah, seems obviously correct, I'll queue it up.

> Rafael, i'm curious is this in response to some regression/bug? Did some
> box or driver get confused by us enabling/disabling the GSI? Some IRQ
> flood perhaps?
>
> btw., there's a small observation:
> > + if (!dev->msi_enabled && !dev->msix_enabled)
>
> maybe a "pci_has_gsi_irq()" wrapper would make these checks cleaner and
> would make things more robust, should there be any new IRQ delivery method
> be introduced in the future?

pci_has_msi_irq surely? Otherwise we'll catch pretty much everything? Or did
you mean !pci_has_gsi_irq() here instead?

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center



\
 
 \ /
  Last update: 2009-01-05 20:55    [from the cache]
©2003-2011 Jasper Spaans