Messages in this thread | | | Date | Mon, 5 Jan 2009 14:55:08 +0100 | From | Ingo Molnar <> | Subject | Re: irqnr fallout in gpiolib on sparc32 |
| |
* Sam Ravnborg <sam@ravnborg.org> wrote:
> > > I did a simple: > > > #include <linux/irqnr.h> but that did not help. > > > > yeah. Does the patch below do the trick? > > Needed a small fix - see below. > > > btw., i'm curious, does the unification of the sparc architectures > > mean that sparc32 will be using genirq too some time in the future? > > Dave has mentioned this but we are not working actively on it yet.
would be cool to do it - i think sparc32 is one of the last major physical architectures to not be on genirq - if we did this conversion we could do a good number of nice cleanups by eliminating all the genirq/non-genirq differences.
> > +#define nr_irqs NR_IRQS > > +#define irq_to_desc(irq) irq_desc[irq] > > irq_to_desc(irq) return a pointer to a struct irq_desc > so we need to take the address. > > > +#define irq_to_desc(irq) &irq_desc[irq] > ^ > With this small fix the build continues.
oops, indeed. I fixed it, added your Tested-by and pushed it into tip/irq/urgent. Thanks Sam!
Ingo
| |