Messages in this thread | | | Date | Mon, 5 Jan 2009 15:32:13 +0200 | From | "Pekka Enberg" <> | Subject | Re: [PATCH V3 12/17] Squashfs: header files |
| |
Hi Phillip,
On Mon, Jan 5, 2009 at 1:08 PM, Phillip Lougher <phillip@lougher.demon.co.uk> wrote: > +#define TRACE(s, args...) pr_debug("SQUASHFS: "s, ## args)
You've probably heard this before but silly "tracing" such as:
TRACE("Entered squashfs_fill_superblock\n");
should really be removed from the filesystem code.
> +#define ERROR(s, args...) pr_err("SQUASHFS error: "s, ## args) > + > +#define WARNING(s, args...) pr_warning("SQUASHFS: "s, ## args)
I think you're supposed to #define pr_fmt() in your header instead of adding wrappers like these.
Pekka
| |