lkml.org 
[lkml]   [2009]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date
In-Reply-To: <20090103191359.GA9304@linux.vnet.ibm.com>

Kamalesh Babulal wrote:
> config SCSI_IBMVSCSI
> tristate "IBM Virtual SCSI support"
> - depends on PPC_PSERIES || PPC_ISERIES
> + depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH
> select SCSI_SRP_ATTRS
> help
> This is the IBM POWER Virtual SCSI Client

As VIOPATH is iSeries code and is only used by the iSeries code, the
requirment should be

depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)

except VIOPATH isn't selectable:

arch/powerpc/platforms/iseries/Kconfig:

config VIOPATH
bool
depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
default y

so instead we should be adding

select VIOPATH if PPC_ISERIES

to SCSI_IBMVSCSI and just

select VIOPATH

to HVC_ISERIES as it depends on PPC_ISERIES

otherwise you have to enable one driver to get these other drivers.

milton



\
 
 \ /
  Last update: 2009-01-04 10:07    [W:0.057 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site