Messages in this thread | | | Date | Sun, 4 Jan 2009 18:21:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] x86: setup.c fix style problems |
| |
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: cleanup, fix style problems, more readable > > Fixes style problems: > WARNING: Use #include <linux/smp.h> instead of <asm/smp.h> > WARNING: Use #include <linux/percpu.h> instead of <asm/percpu.h> > WARNING: Use #include <linux/topology.h> instead of <asm/topology.h> > WARNING: externs should be avoided in .c files > ERROR: code indent should use tabs where possible > > total: 2 errors, 4 warnings
doesnt build on some configs:
arch/x86/kernel/setup.c:943: error: implicit declaration of function 'prefill_possible_map'
the x86-local declarations in smp.h should probably be moved into a separate smp_x86.h file - to avoid such trouble.
Ingo
| |