Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/4] kthreads: simplify the startup synchronization | Date | Sat, 31 Jan 2009 22:09:40 +1030 |
| |
On Friday 30 January 2009 23:03:54 Oleg Nesterov wrote: > We use two completions two create the kernel thread, this is a bit ugly. > kthread() wakes up create_kthread() via ->started, then create_kthread() > wakes up the caller kthread_create() via ->done. But kthread() does not > need to wait for kthread(), it can just return. Instead kthread() itself > can wake up the caller of kthread_create(). > > Kill kthread_create_info->started, ->done is enough. This improves the > scalability a bit and sijmplifies the code. > > The only problem if kernel_thread() fails, in that case create_kthread() > must do complete(&create->done). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Nice! I'll apply this one after the minor respin of 1/4.
Thanks, Rusty.
| |