lkml.org 
[lkml]   [2009]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.29-rc libata sff 32bit PIO regression
Hello.

Alan Cox wrote:

>>> + if (pdev->device == PCI_DEVICE_ID_AMD_VIPER_7411) /* FIFO is broken */
>>> + fifo = 0;
>>> +
>>> + /* On the later chips the read prefetch bits become no-op bits */
>>> + pci_read_config_byte(pdev, 0x41, &r);
>>> + r &= ~fifobit[ap->port_no];
>>>
>>>
>> Why not:
>>
>> r &= ~fifo;
>>
>
> Because then it wouldn't clear the bits if they were set already and we
> wanted them off!
>

Ah, missed the modification of 'fifo'... :-<

MBR, Sergei




\
 
 \ /
  Last update: 2009-01-31 17:59    [W:0.038 / U:0.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site