Messages in this thread | | | Date | Fri, 30 Jan 2009 08:52:49 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c |
| |
On Fri, Jan 30, 2009 at 01:42:52AM -0700, Paul Walmsley wrote: > I haven't looked closely at your above three patches for this, but plan to > do so later today. > > Regarding provenance, the patches that I sent you were developed > independently, for clock notifier support. Ultimately, I have no personal > attachment as to whose patches for this go in, if all technical aspects > are equal.
There's one bug that your version highlights in mine - the virtual mpu clock in omap1 touches the DPLL and repropagates that rate. I've removed that repropagation, so that needs fixing.
However, this raises a question: why is the virtual mpu clock touching some other part of the clock tree. I wonder whether this should be handled a different way, though the first thing that needs answering is why we have this alias for 'arm_ck' ?
| |