Messages in this thread Patch in this message | | | Date | Fri, 30 Jan 2009 18:42:23 -0800 | From | Greg KH <> | Subject | [patch 05/43] fuse: fix missing fput on error |
| |
2.6.28-stable review patch. If anyone has any objections, please let us know.
------------------
From: Miklos Szeredi <mszeredi@suse.cz>
commit 3ddf1e7f57237ac7c5d5bfb7058f1ea4f970b661 upstream.
Fix the leaking file reference if allocation or initialization of fuse_conn failed.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- fs/fuse/inode.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
--- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -825,12 +825,16 @@ static int fuse_fill_super(struct super_ if (!file) return -EINVAL; - if (file->f_op != &fuse_dev_operations) + if (file->f_op != &fuse_dev_operations) { + fput(file); return -EINVAL; + } fc = new_conn(sb); - if (!fc) + if (!fc) { + fput(file); return -ENOMEM; + } fc->flags = d.flags; fc->user_id = d.user_id;
| |