lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: push old stack address on irqstack for unwinder

* H. Peter Anvin <hpa@zytor.com> wrote:

> Ingo Molnar wrote:
>>
>> Would be nice to have an #ifdef-less primitive for this - something like:
>>
>> pushq_frame %rbp
>>
>> and a matching:
>>
>> popq_frame %rbp
>>
>> for those cases that need it (this one doesnt as we dont pop out of the
>> stack).
>>
>
> It certainly would if this isn't a singleton, which I think it could
> possibly be?

yeah. This is pretty much the only non-restored frame we construct so
indeed it would be a singleton. Perhaps the IST ones are such ones too.

> Otherwise it really should be a part of an entry/exit macro; this is
> somewhat special in that it sets up a frame pointer as something other
> than a normal entry/exit sequence.

Sure - your call really.

Ingo


\
 
 \ /
  Last update: 2009-01-31 01:53    [W:0.087 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site