lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: push old stack address on irqstack for unwinder
H. Peter Anvin wrote:
> Martin Hicks wrote:
>> Hi,
>>
>> KDB was using this information. Could this be pushed towards 2.6.29
>> please?
>>
>> This re-adds the old stack pointer to the top of the irqstack to help
>> with unwinding. It was removed in commit
>> d99015b1abbad743aa049b439c1e1dede6d0fa49
>> as part of the save_args out-of-line work.
>>
>
> This bothers me... why should we add even a single instruction to what
> is arguably the single hottest path in the kernel to support an
> out-of-tree debugger, especially if kgdb (which is in-tree) doesn't need
> it?
>
> What does kgdb do differently (or is kgdb broken too)?
>

Thinking about it some more, I think this makes sense under

#ifdef CONFIG_FRAME_POINTER

... since if we're not building with frame pointers, this is pretty
pointless, and if we are, we're adding these all over the place anyway.

Does this work for you? Let me know and I'll get it in if so.

-hpa


\
 
 \ /
  Last update: 2009-01-31 01:39    [W:0.203 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site