lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] ACPICA: Fix truncation message calculation
Date
Len:

The following two item patch series fixes a calculation in
./drivers/acpi/tables/tbutils.c::acpi_tb_parse_root_table() that
determines how many ACPI table entries will be truncated when the
number of RSDT/XSDT entries is greater than the statically allocated
'initial_tables[]' array.

As currently implemented, the calculation will always yield a value
of 0. The following output shows the issue (Note the line with
"...: Truncating ..." which incorrectly indicates 0):
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126]
ACPI Warning (tbutils-0519): Truncating 0 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0)
ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...

With the patch applied, the output correctly shows the number of
(missing) truncated entries:
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126]
ACPI Warning (tbutils-0519): Truncating 5 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0)
ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...


[PATCH 1/2] fixes the truncation message related calculation.

[PATCH 2/2] is non-functional white space fixes - 80 column adherence -
for the same file.


The underlying code affected is common to both x86 and ia64. I have
tested the patch on an ia64 platform.

All comments welcome.

Myron
---

Myron Stowe (2):
ACPICA: 80 column adherence (no functional change)
ACPICA: Fix table entry truncation calculation


drivers/acpi/acpica/tbutils.c | 43 +++++++++++++++++++++++++++--------------
1 files changed, 28 insertions(+), 15 deletions(-)



\
 
 \ /
  Last update: 2009-01-30 23:47    [W:0.241 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site