Messages in this thread | | | Date | Fri, 30 Jan 2009 14:03:46 -0800 (PST) | Subject | Re: [PATCH v2] tcp: splice as many packets as possible at once | From | David Miller <> |
| |
From: Willy Tarreau <w@1wt.eu> Date: Fri, 30 Jan 2009 22:59:20 +0100
> On Fri, Jan 30, 2009 at 01:42:27PM -0800, David Miller wrote: > > It's cheesy and the SLAB developers will likely barf at the > > idea, but it would certainly work. > > Maybe that would be enough as a definitive fix for a stable > release, so that we can go on with deeper changes in newer > versions ?
Such a check could have performance ramifications, I wouldn't risk it and already I intend to push Jarek's page allocator splice fix back to -stable eventually.
> > Back to real life, I think long term the thing to do is to just do the > > cached page allocator thing we'll be doing after Jarek's socket page > > patch is integrated, and for best performance the driver has to > > receive it's data into pages, only explicitly pulling the ethernet > > header into the linear area, like NIU does. > > Are there NICs out there able to do that themselves or does the > driver need to rely on complex hacks in order to achieve this ?
Any NIC, even the dumbest ones, can be made to receive into pages.
| |