Messages in this thread | | | Date | Sat, 31 Jan 2009 01:40:50 +0900 (JST) | Subject | Re: [PATCH 09/13] atmel-mci: convert to dma_request_channel and down-level dma_slave | From | Atsushi Nemoto <> |
| |
On Fri, 14 Nov 2008 14:35:03 -0700, Dan Williams <dan.j.williams@intel.com> wrote: > dma_request_channel provides an exclusive channel, so we no longer need to > pass slave data through dmaengine. > > Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Sorry for late review... I hope not too late.
> @@ -789,23 +782,17 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan, > cfghi = DWC_CFGH_FIFO_MODE; > cfglo = 0; > > - slave = client->slave; > - if (slave) { > + dws = dwc->dws; > + if (dws) { > /* > * We need controller-specific data to set up slave > * transfers. > */ > - BUG_ON(!slave->dma_dev || slave->dma_dev != dw->dma.dev); > - > - dws = container_of(slave, struct dw_dma_slave, slave); > + BUG_ON(!dws->dma_dev || dws->dma_dev != dw->dma.dev); > > - dwc->dws = dws;
How dw_dma_slave passed to the dw_dmac driver? I cannot see where dwc->dws is initialized now. Or am I missing something?
--- Atsushi Nemoto
| |