Messages in this thread | | | Date | Thu, 29 Jan 2009 01:28:00 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 3 of 7] x86: fix paravirt clobber in entry_64.S |
| |
Rusty Russell wrote: > On Thursday 29 January 2009 09:05:03 Jeremy Fitzhardinge wrote: > >> The clobber is trying to say that anything except RDI is available for >> clobbering, but actually clobbers everything. This hasn't mattered >> because the clobbers were basically ignored, but subsequent patches >> will rely on them. >> >> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> >> > > Acked-by: Rusty Russell <rusty@rustcorp.com.au> > > Hmm, did we never have the deliberate-clobbering debug code for 64 bit? >
No. I think I killed it off before 64-bit was even started. There was some confusion about whether the return regs were considered to be "clobbered" or not, but I don't remember the details.
J
| |