lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3 of 7] x86: fix paravirt clobber in entry_64.S
Rusty Russell wrote:
> On Thursday 29 January 2009 09:05:03 Jeremy Fitzhardinge wrote:
>
>> The clobber is trying to say that anything except RDI is available for
>> clobbering, but actually clobbers everything. This hasn't mattered
>> because the clobbers were basically ignored, but subsequent patches
>> will rely on them.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Hmm, did we never have the deliberate-clobbering debug code for 64 bit?
>

No. I think I killed it off before 64-bit was even started. There was
some confusion about whether the return regs were considered to be
"clobbered" or not, but I don't remember the details.

J


\
 
 \ /
  Last update: 2009-01-29 10:31    [W:0.043 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site