lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH -v2] use per cpu data for single cpu ipi calls
    Date
    On Friday 30 January 2009 04:38:23 Linus Torvalds wrote:
    >
    > On Thu, 29 Jan 2009, Steven Rostedt wrote:
    > >
    > > Actually, we are locking against the destination CPU.
    >
    > Oh.
    >
    > THAT'S JUST INCOMPETENT.
    >
    > What the *fuck* is the point of having per-CPU data, and then using it for
    > the wrong CPU?

    Maybe we made it too easy to declare and use per-cpu data?

    Could we use an nr_cpu_ids array? Yes, it needs alloc at boot somewhere, but
    it avoids collateral damage to other percpu data (and please don't suggest DEFINE_PER_CPU_SHARED_ALIGNED: that's just antisocial).

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2009-01-30 02:59    [W:0.020 / U:91.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site