Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 4 of 7] x86/paravirt: selectively save/restore regs around pvops calls | Date | Fri, 30 Jan 2009 10:57:27 +1030 |
| |
On Thursday 29 January 2009 20:00:34 Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > It's kind of messy. Can we do something clever here with token pasting? > > I tried a few things, but no. Passing in just RAX, and then pasting > CLBR_##reg works, and the assembler accepts %RAX - but - the asm code > also #defines RAX <some stack offset>, so the assembler ends up seeing > %48. I considered renaming all the CLBR_ defines to CLBR_rax, but that > looks unhappy too. So I stayed with this.
OK, then Acked-by: Rusty Russell <rusty@rustcorp.com.au> on this one too.
Thanks, Rusty.
| |