lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/6] Hibernation: Introduce system_entering_hibernation
    Date
    On Thursday 29 January 2009, Pavel Machek wrote:
    > On Mon 2009-01-19 20:54:54, Rafael J. Wysocki wrote:
    > > From: Rafael J. Wysocki <rjw@sisk.pl>
    > >
    > > Introduce boolean function system_entering_hibernation() returning
    > > 'true' during the last phase of hibernation, in which devices are
    > > being put into low power states and the sleep state (for example,
    > > ACPI S4) is finally entered.
    >
    > ...this paragraph...
    >
    > > Index: linux-2.6/kernel/power/disk.c
    > > ===================================================================
    > > --- linux-2.6.orig/kernel/power/disk.c
    > > +++ linux-2.6/kernel/power/disk.c
    > > @@ -71,6 +71,14 @@ void hibernation_set_ops(struct platform
    > > mutex_unlock(&pm_mutex);
    > > }
    >
    > ....should go somewhere here. Because the name does not imply it is
    > for last phases, only...
    >
    > > +static bool entering_platform_hibernation;
    > > +
    > > +bool system_entering_hibernation(void)
    > > +{
    > > + return entering_platform_hibernation;
    > > +}
    > > +EXPORT_SYMBOL(system_entering_hibernation);
    > > +
    > > #ifdef CONFIG_PM_DEBUG
    > > static void hibernation_debug_sleep(void)
    > > {
    > > @@ -411,6 +419,7 @@ int hibernation_platform_enter(void)
    > > if (error)
    > > goto Close;
    > >
    > > + entering_platform_hibernation = true;
    > > suspend_console();
    >
    > Why entering _platform_ hibernation? It will not be set for echo
    > shutdown > disk case?

    If I remember correctly, no, it won't.

    Thanks,
    Rafael


    \
     
     \ /
      Last update: 2009-01-29 15:53    [W:0.057 / U:269.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site