Messages in this thread | | | Date | Thu, 29 Jan 2009 14:37:33 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH D 11/11] Fix omap1 clock issues |
| |
On Wed, Jan 28, 2009 at 12:18:48PM -0700, Paul Walmsley wrote: > From: Tony Lindgren <tony@atomide.com> > > This fixes booting, and is a step toward fixing things properly: > > - Make enable_reg u32 instead of u16
No, you're passing this to __raw_read/write, so it needs to be void __iomem *, not u32. If there's another patch doing that it needs to be combined with this one. The miniscule details of fixes upon fixes aren't interesting for submission purposes, and just adds extra unnecessary review load for upstream people.
Ditto for anything else which is passed to __raw_read/write*.
| |