Messages in this thread | | | Date | Thu, 29 Jan 2009 14:33:08 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] - UV fix compile error on IA64 & eliminate compiler warning |
| |
* Jack Steiner <steiner@sgi.com> wrote:
> > The GRU driver is used on both IA64 & x86. > The 2 architectures have different ways of detecting the > platform type, ie. whether the platform is a UV system. > Although it is possible to reconcile the 2 methods, > only one place currently makes the test. > > Also eliminate a warning message in uv.h. > > Signed-off-by: Jack Steiner <steiner@sgi.com> > > > --- > arch/x86/include/asm/uv/uv.h | 1 + > drivers/misc/sgi-gru/gru.h | 2 -- > drivers/misc/sgi-gru/grufile.c | 1 + > 3 files changed, 2 insertions(+), 2 deletions(-) > > Index: linux/arch/x86/include/asm/uv/uv.h > =================================================================== > --- linux.orig/arch/x86/include/asm/uv/uv.h 2009-01-28 12:43:27.000000000 -0600 > +++ linux/arch/x86/include/asm/uv/uv.h 2009-01-28 15:13:58.000000000 -0600 > @@ -2,6 +2,7 @@ > #define _ASM_X86_UV_UV_H > > enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC, UV_NON_UNIQUE_APIC}; > +struct mm_struct;
hm, why is this needed?
> #define IS_UV() is_uv_system()
btw., why is there an ugly IS_UV() macro. All code should be using is_uv_system() and IS_UV() should be removed.
Ingo
| |