lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [: [git pull] headers_check fixes]
On Tue, Jan 27, 2009 at 02:57:23PM -0800, Linus Torvalds wrote:
>
>
> On Tue, 27 Jan 2009, Ingo Molnar wrote:
> >
> > Should i perhaps not bother with the stuff below? Cannot turn off
> > CONFIG_HEADERS_CHECK in my builds because it can cause build failures.
>
> I really hate the patch. I think it's fundamentally flawed. I hate scripts
> that test for things that are readable, and encourage people to then write
> crap instead.
>
> The thing is, the headers_check stuff is just wrong if it causes these
> things, and I'd rather just turn it off.
>
> If those
>
> #ifdef CONFIG_XYZ
>
> things result in problems, then we should just make the rule be that we
> turn that kind of string into
>
> #if 0
>
> automatically when exporting the kernel headers. IOW, just about
> _anything_ that headers_check complains about automatically is something
> that should just be _fixed_ automatically at header install time rather
> than make the code harder to read.

Almost every single patch that makes code harder to read while removing
CONFIG_ references from the exported headers just take the wrong approach.

I read later in this thread that Ingo is planning to filter out these patches
so we can get the other ones in - good.

What we should try to do is to look at the bigger picture.
Sometimes the right answer is that this whole file should not
be exported or maybe only half should be exported.
But due to the fact that we have no established way to seperate
what is internal and what is exported *on the file level* people
keep sprinkling #ifdef __KERNEL__ all over the header files.

I checked include/linux - we have 494 places where we reference __KERNEL__
And that is in 237 files.
We export 354 files from this dir - so we already have > 100 files that is
exported to userspace without modifications.
So rather than start sprinkling the exported headers with "if 0" then
we should encourage to clean them and when accetable move them to
a dedicated abi directory.

This may need some cooperation with external parties such as glibc
and other libc variants. And we could improve here.

Sam


\
 
 \ /
  Last update: 2009-01-28 22:07    [from the cache]
©2003-2011 Jasper Spaans