Messages in this thread | | | Date | Wed, 28 Jan 2009 09:09:24 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [FIX][PATCH 6/7] cgroup/memcg: fix frequent -EBUSY at rmdir |
| |
On Mon, 26 Jan 2009 16:58:23 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Thu, 22 Jan 2009 18:40:18 +0900 KAMEZAWA Hiroyuki wrote: > > > Documentation/cgroups/cgroups.txt | 6 +- > > include/linux/cgroup.h | 16 +----- > > kernel/cgroup.c | 97 ++++++++++++++++++++++++++++++++------ > > mm/memcontrol.c | 5 + > > 4 files changed, 93 insertions(+), 31 deletions(-) > > > > Index: mmotm-2.6.29-Jan16/Documentation/cgroups/cgroups.txt > > =================================================================== > > --- mmotm-2.6.29-Jan16.orig/Documentation/cgroups/cgroups.txt > > +++ mmotm-2.6.29-Jan16/Documentation/cgroups/cgroups.txt > > @@ -478,11 +478,13 @@ cgroup->parent is still valid. (Note - c > > newly-created cgroup if an error occurs after this subsystem's > > create() method has been called for the new cgroup). > > > > -void pre_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp); > > +int pre_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp); > > > > Called before checking the reference count on each subsystem. This may > > be useful for subsystems which have some extra references even if > > -there are not tasks in the cgroup. > > +there are not tasks in the cgroup. If pre_destroy() returns error code, > > +rmdir() will fail with it. From this behavior, pre_destroy() can be > > +called plural times against a cgroup. > > s/plural/multiple/ please. > ok, thank you for review.
-Kame
> > > > int can_attach(struct cgroup_subsys *ss, struct cgroup *cgrp, > > struct task_struct *task) > > > --- > ~Randy > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |