Messages in this thread | | | Date | Mon, 26 Jan 2009 13:16:14 +0100 | From | Heiko Carstens <> | Subject | Re: [PATCH] sysrq: include interrupt.h instead of irq.h |
| |
On Wed, 21 Jan 2009 08:50:03 -0800 Mike Travis <travis@sgi.com> wrote:
> Thanks for catching this Heiko! > Mike
Erm... it still breaks. Are you going to add the patch to your tree?
> Heiko Carstens wrote: > > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > > > With "cpumask: update irq_desc to use cpumask_var_t" in linux-next > > we get this compile bug on s390: > > > > CC drivers/char/sysrq.o > > In file included from drivers/char/sysrq.c:38: > > include/linux/irq.h: In function 'init_alloc_desc_masks': > > include/linux/irq.h:442: error: dereferencing pointer to incomplete type > > > > drivers/char/sysrq.c should include interrupt.h instead of irq.h. > > > > Cc: Mike Travis <travis@sgi.com> > > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > > --- > > drivers/char/sysrq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-next/drivers/char/sysrq.c > > =================================================================== > > --- linux-next.orig/drivers/char/sysrq.c > > +++ linux-next/drivers/char/sysrq.c > > @@ -35,7 +35,7 @@ > > #include <linux/vt_kern.h> > > #include <linux/workqueue.h> > > #include <linux/kexec.h> > > -#include <linux/irq.h> > > +#include <linux/interrupt.h> > > #include <linux/hrtimer.h> > > #include <linux/oom.h>
| |