lkml.org 
[lkml]   [2009]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe()
    From
    On Mon, Jan 26, 2009 at 8:03 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
    > Greg KH wrote:
    >>
    >> On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote:
    >>>
    >>> From: Pekka Enberg <penberg@cs.helsinki.fi>
    >>>
    >>> If successful, the usb_control_msg() function returns the number of
    >>> bytes transferred. Fix up wb35_probe() to only bail out if the function
    >>> returns a negative number.
    >>>
    >>> Reported-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
    >>> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
    >>
    >> I'm confused, should I apply this patch or not?
    >
    > Yes, you should. What's confusing you here?

    Oh, looking at the thread, I see how you got confused. The patch
    doesn't fix all of Sandro's problems but is an obvious improvement so
    it should be merged.


    \
     
     \ /
      Last update: 2009-01-26 19:13    [W:0.023 / U:178.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site