lkml.org 
[lkml]   [2009]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] autofs: fix the wrong usage of the deprecated task_pgrp_nr()
    From
    Date
    On Fri, 2009-01-23 at 09:13 +0100, Oleg Nesterov wrote:
    > On 01/23, Ian Kent wrote:
    > >
    > > But I think that for debug logging we should always report numbers that
    > > correspond to the object as it is seen in the global namespace as that
    > > is the most likely reference point someone examining debug logging will
    > > be working from.
    > >
    > > Oleg, what should be the recommended call to report that, instead of the
    > > task_pgrp_nr() call?
    >
    > task_pgrp_nr_ns(tsk, &init_pid_ns) gives the same result. Except, if the
    > tsk has already exited it returns 0.
    >
    >
    > But, Ian, if you prefer to use task_pgrp_nr() - just use it. Personally,
    > I'd like to kill task_pgrp_nr(), but I can't "prove" it should die.

    I'm not concerned with what's used so much as fitting in with the pid
    namespace effort and maintaining sensible debug output. This stuff has
    been in autofs4 since long before the pid namespace work began and the
    changes to it weren't done by me anyway.

    Ian




    \
     
     \ /
      Last update: 2009-01-23 10:13    [W:0.020 / U:148.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site