lkml.org 
[lkml]   [2009]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, RFC] Remove fasync() BKL usage, take 3325
On Fri, 23 Jan 2009 06:54:04 +0100
Andi Kleen <andi@firstfloor.org> wrote:

> The state needs to be protected while the per driver ->fasync callback
> runs, otherwise the bit can get out of sync with what the driver
> thinks it is.
>
> Mind you imho the best way would be to move the bit manipulation for
> that into the drivers, but that would require to change them all.

You know, I'm not sure why I didn't look into that. Do we want drivers
reaching directly into struct file and making changes? Maybe a helper
would be better. Hmm, maybe we could call it fasync_helper() and it
could just do the right thing? Will investigate further...

jon


\
 
 \ /
  Last update: 2009-01-23 07:05    [W:0.066 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site