Messages in this thread | | | Date | Fri, 23 Jan 2009 04:31:33 +0100 | From | Nick Piggin <> | Subject | Re: [patch] SLQB slab allocator |
| |
On Wed, Jan 21, 2009 at 06:40:10PM +0100, Ingo Molnar wrote: > > * Nick Piggin <npiggin@suse.de> wrote: > > > On Wed, Jan 21, 2009 at 03:59:18PM +0100, Ingo Molnar wrote: > > > > > > Mind if i nitpick a bit about minor style issues? Since this is going to > > > be the next Linux SLAB allocator we might as well do it perfectly :-) > > > > Well here is an incremental patch which should get most of the issues > > you pointed out, most of the sane ones that checkpatch pointed out, and > > a few of my own ;) > > here's an incremental one ontop of your incremental patch, enhancing some > more issues. I now find the code very readable! :-)
Thanks! I'll go through it and apply it. I'll raise any issues if I am particularly against them ;)
> ( in case you are wondering about the placement of bit_spinlock.h - that > file needs fixing, just move it to the top of the file and see the build > break. But that's a separate patch.)
Ah, SLQB doesn't use bit spinlocks anyway, so I'll just get rid of that. I'll see if there are any other obviously unneeded headers too.
Thanks, Nick
| |