lkml.org 
[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Re: Corrupted XFS log replay oops.
    * Christoph Hellwig (hch@infradead.org) wrote:
    > On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
    > > xfs_buf_t *
    > > xlog_get_bp(
    > > xlog_t *log,
    > > - int num_bblks)
    > > + int nbblks)
    >
    > Any reason for reanming this variable? That causes quite a bit of
    > churn.
    >
    > > {
    > > - ASSERT(num_bblks > 0);
    > > + if (nbblks <= 0 || nbblks > log->l_logBBsize) {
    > > + xlog_warn("XFS: Invalid block length (0x%x) given for buffer", nbblks);
    >
    > And doesn't prevent this line from needing a linebreak to stay under 80
    > characters :)
    >
    > Except for these nitpicks it looks fine to me.

    Just want to report that it fixes the issue for me. Thanks,
    i will continue xfs testing.

    Greetings, Eric


    \
     
     \ /
      Last update: 2009-01-22 09:39    [W:3.636 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site