Messages in this thread | | | From | Carlos Corbacho <> | Subject | Re: [PATCH] Make PNP IDs all uppercase | Date | Thu, 22 Jan 2009 23:03:38 +0000 |
| |
On Sunday 18 January 2009 14:02:32 Philipp Kohlbecher wrote: > If I understand correctly, ACPI _HIDs (including PNP IDs) should be all > uppercase, including the hex digits, cf. ACPI Specification 3.0b [1], > pp. 162-3 and acpi_glb_hex_to_ascii[] in drivers/acpi/utilities/utglobal.c.
ACPI-WMI violates the spec here.
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c > index 8a8b377..79b8af7 100644 > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -84,7 +84,7 @@ static int acpi_wmi_add(struct acpi_device *device); > > static const struct acpi_device_id wmi_device_ids[] = { > {"PNP0C14", 0}, > - {"pnp0c14", 0}, > + {"PNP0C14", 0}, > {"", 0}, > }; > MODULE_DEVICE_TABLE(acpi, wmi_device_ids); > diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c > index 8473fe5..18c9335 100644
NAK to the ACPI-WMI changes. There really is a pnp0c14 and a PNP0C14, and removing the lower case version breaks ACPI-WMI on my laptop.
-Carlos -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D
| |