Messages in this thread | | | Date | Fri, 23 Jan 2009 00:32:15 +0200 | Subject | Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() | From | Pekka Enberg <> |
| |
On Thu, Jan 22, 2009 at 11:19 PM, Harvey Harrison <harvey.harrison@gmail.com> wrote: > On Thu, 2009-01-22 at 22:10 +0100, Pavel Machek wrote: >> On Thu 2009-01-22 20:25:06, Sandro Bonazzola wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > Pavel Machek ha scritto: >> > >> From: Pekka Enberg <penberg@cs.helsinki.fi> >> > >> >> > >> If successful, the usb_control_msg() function returns the number of >> > >> bytes transferred. Fix up wb35_probe() to only bail out if the function >> > >> returns a negative number. >> > >> >> > >> Reported-by: Sandro Bonazzola <sandro.bonazzola@gmail.com> >> > >> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> >> > > >> > > Acked-by: Pavel Machek <pavel@suse.cz> >> > >> > Ok, tested. Here is the result: >> > >> > # uname -a >> > Linux arilinn 2.6.29-rc2-00013-gf3b8436-dirty #1 Thu Jan 22 19:39:23 CET 2009 >> > x86_64 AMD Athlon(tm) 64 Processor 3500+ AuthenticAMD GNU/Linux >> > >> > Inserting the USB device: >> > # dmesg >> > usb 1-3: new high speed USB device using ehci_hcd and address 4 >> > usb 1-3: New USB device found, idVendor=18e8, idProduct=6201 >> > usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 >> > usb 1-3: Product: Usb2Wlan >> > usb 1-3: Manufacturer: WINBOND >> > usb 1-3: SerialNumber: 101d350112 >> > usb 1-3: configuration #1 chosen from 1 choice >> > w35und: module is from the staging directory, the quality is unknown, you have >> > been warned. >> > wmaster0 (usb): not using net_device_ops yet >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> This looks like a key clue... >> >> Maybe you could try _current_ w35und on 2.6.28 or something like that? >> I have feeling that networking core changed in incompatible way here. >> > > I thought the net-device-ops conversion was opt in? It shouldn't break > anything if the driver hasn't been converted yet.
Looking at commit d314774cf2cd5dfeb39a00d37deee65d4c627927 ("netdev: network device operations infrastructure") that seems to be the case.
Pekka
| |