Messages in this thread | | | Date | Thu, 22 Jan 2009 21:13:30 +0100 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH 13/13] drivers/watchdog: use USB API functions rather than constants |
| |
Hi Julia,
> > diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c > > index afb0896..b5320a8 100644 > > --- a/drivers/watchdog/pcwd_usb.c > > +++ b/drivers/watchdog/pcwd_usb.c > > @@ -609,9 +609,7 @@ static int usb_pcwd_probe(struct usb_interface *interface, const struct usb_devi > > /* check out the endpoint: it has to be Interrupt & IN */ > > endpoint = &iface_desc->endpoint[0].desc; > > > > - if (!((endpoint->bEndpointAddress & USB_DIR_IN) && > > - ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) > > - == USB_ENDPOINT_XFER_INT))) { > > + if (!usb_endpoint_is_int_in(endpoint)) { > > /* we didn't find a Interrupt endpoint with direction IN */ > > printk(KERN_ERR PFX "Couldn't find an INTR & IN endpoint\n"); > > return -ENODEV; > > Seems OK. I will test it this week and let you know.
Tested OK.
Will I add this into the watchdog-tree so that it can go mainline?
Kind regards, Wim.
| |