lkml.org 
[lkml]   [2009]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/10] mmc: Add OpenFirmware bindings for SDHCI driver
Date
On Thursday 22 January 2009, Anton Vorontsov wrote:
> This patch adds a new driver: sdhci-of. The driver is similar to
> the sdhci-pci, it contains common probe code, and controller-specific
> ops and quirks.
>
> So far there are only Freescale eSDHC ops and quirks.

Looks very good overall.

Acked-by: Arnd Bergmann <arnd@arndb.de>

> + ret = of_address_to_resource(np, 0, &mem);
> + if (ret)
> + goto err_no_addr;
> +
> + host->ioaddr = ioremap(mem.start, resource_size(&mem));
> + if (!host->ioaddr) {
> + ret = -ENOMEM;
> + goto err_addr_map;
> + }

Minor improvement: you could use of_iomap to do this in one step.

Arnd <><


\
 
 \ /
  Last update: 2009-01-22 13:07    [from the cache]
©2003-2011 Jasper Spaans