Messages in this thread | | | Date | Wed, 21 Jan 2009 08:44:56 -0800 | From | "H. Peter Anvin" <> | Subject | Re: Confusion in usr/include/asm-generic/fcntl.h |
| |
Arnd Bergmann wrote: > > I would prefer using the __BITS_PER_LONG == 64 check directly, because > it gives you a warning when __BITS_PER_LONG is undefined, whereas the > #ifdef check gets easily fooled by include order problems. Note that > this is not a problem in the kernel for CONFIG_* symbols which are > always defined before the first #include. >
I fully agree with this. It actually *is* a problem for CONFIG_* symbols too, since people typo them all the time.
-hpa
| |