Messages in this thread | | | Date | Tue, 20 Jan 2009 09:16:16 -0800 (PST) | Subject | Re: [PATCH v2] tcp: splice as many packets as possible at once | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Tue, 20 Jan 2009 11:01:44 +0000
> On Tue, Jan 20, 2009 at 01:31:22PM +0300, Evgeniy Polyakov wrote: > > On Tue, Jan 20, 2009 at 10:20:53AM +0000, Jarek Poplawski (jarkao2@gmail.com) wrote: > > > Good question! Alas I can't check this soon, but if it's really like > > > this, of course this needs some better idea and rework. (BTW, I'd like > > > to prevent here as much as possible some strange activities like 1 > > > byte (payload) packets getting full pages without any accounting.) > > > > I believe approach to meet all our goals is to have own network memory > > allocator, so that each skb could have its payload in the fragments, we > > would not suffer from the heavy fragmentation and power-of-two overhead > > for the larger MTUs, have a reserve for the OOM condition and generally > > do not depend on the main system behaviour. > > 100% right! But I guess we need this current fix for -stable, and I'm > a bit worried about safety.
Jarek, we already have a page and offset you can use.
It's called sk_sndmsg_page but that is just the (current) name. Nothing prevents you from reusing it for your purposes here.
| |