lkml.org 
[lkml]   [2009]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kthread: Don't looking for a task in create_kthread() #2
    On 01/20, Vitaliy Gusev wrote:
    >
    > On 20 January 2009 15:06:42 Oleg Nesterov wrote:
    > >
    > > BTW. Perhaps it also makes sense to move sched_setscheduler/etc code
    > > from create_kthread() to kthread_create(), what do you think?
    >
    > I don't thinks so. create_kthread() is executed in kthreadd process and
    > sched_setscheduler/etc preparation things are reflected to kthreadd's CPU usage.
    > In other words it is a kthreadd matter, start and setup a thread.

    can't understand...

    Perhaps I missed something, but from the correctness pov it doesn't
    matter who does sched_setscheduler/etc (except _nocheck() would be
    better). However it does matter from the scalability pov, we should
    move as much as possible from create_kthread() because we have a
    single process with executes the "create" requests.

    OK, please forget. This reminds me kthread.c needs a major rework
    anyway, hopefully I'll try to do this soon.

    Oleg.



    \
     
     \ /
      Last update: 2009-01-20 16:05    [W:0.027 / U:0.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site