lkml.org 
[lkml]   [2009]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: regulator: Add always off to constraints.
Mark Brown wrote:
> On Tue, Jan 20, 2009 at 12:07:05PM +0000, Jonathan Cameron wrote:
>
>> 1) interaction between always on and always off. Obviously it's
>> a bit odd if both are set. Currently I'm giving always on preference.
>
> I'd just complain loudly and refuse to accept the constraints if they
> are clearly broken like that.
Will do.
>
> One thing I would suggest is a slightly weaker version which marks the
> regulator to be turned off at boot rather than always off. That's
> slightly more flexible and would achieve the same effect if the
> constraints don't otherwise allow for turning the regulator on layer.
Good idea. That should just mean removing the code in the enable bit
(and renaming the variable!) I'll repost shortly.
>
>> 2) Doesn't really make sense to have regulators that are always
>> disabled available under sysfs etc. Perhaps there is a lower
>> level way of doing this that I'm missing? There is not easy
>> way of permanently saving this stuff on the da9030 that I'm
>> using and moving it into the bootloader would be a pain.
>
> It doesn't do *that* much harm - if nothing else it makes it more
> discoverable what's happening.
Good point.

Thanks for the comments,

Jonathan


\
 
 \ /
  Last update: 2009-01-20 14:03    [W:0.064 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site